codeant-ai-for-open-source[bot] commented on code in PR #41969:
URL: https://github.com/apache/superset/pull/41969#discussion_r3564778739
##########
tests/integration_tests/security/row_level_security_tests.py:
##########
@@ -492,6 +492,57 @@ def test_rls_subjects_related_api(self):
assert data["count"] > 0
assert len(result) > 0
+ def test_rls_subjects_related_api_honors_filter_31466(self):
Review Comment:
**Suggestion:** Add an explicit return type annotation to this new test
method (for example, indicating it returns no value) to satisfy the type-hint
requirement for modified functions. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The new test method is missing an explicit return type annotation. Under the
Python type-hint rule, modified functions should be annotated, and test methods
that return nothing should still declare `-> None`.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e5a68447ca5a4eef8e96d63a8832131a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e5a68447ca5a4eef8e96d63a8832131a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/security/row_level_security_tests.py
**Line:** 495:495
**Comment:**
*Custom Rule: Add an explicit return type annotation to this new test
method (for example, indicating it returns no value) to satisfy the type-hint
requirement for modified functions.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41969&comment_hash=1ce1f2ec0a4ff559c54ed8fd584879410c3340c2b9aad89aac248abab45fd950&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41969&comment_hash=1ce1f2ec0a4ff559c54ed8fd584879410c3340c2b9aad89aac248abab45fd950&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
