rusackas commented on PR #41953: URL: https://github.com/apache/superset/pull/41953#issuecomment-4948992104
Same blocker as the databricks bump over in #41954: sqlalchemy-hana 4.x requires `sqlalchemy>=2`, and we're on `sqlalchemy>=1.4, <2`, so `apache-superset[hana]` wouldn't resolve. It's not a HANA version thing (our `hdbcli==2.28.21` still satisfies its `hdbcli~=2.10`), just the SQLAlchemy 2 jump. That said, 0.4.0 is ancient, and sqlalchemy-hana 3.0.3 still supports `sqlalchemy<3, >=1.4.0`, so it works fine with our current SQLAlchemy. Retargeting this to 3.0.3 instead of 4.6.0 would be a big, safe modernization we could actually take. Happy to push that change if we want it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
