codeant-ai-for-open-source[bot] commented on code in PR #41970: URL: https://github.com/apache/superset/pull/41970#discussion_r3565442861
########## superset/utils/legacy_thumbnails.py: ########## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Thumbnail helpers for report screenshots.""" +from io import BytesIO + +from PIL import Image, ImageDraw, ImageFont + +# Module-level: on Pillow >=10 this raises AttributeError at import time. +RESAMPLE_FILTER = Image.ANTIALIAS Review Comment: **Suggestion:** Add an explicit type annotation for this module-level variable so static type checking can validate its expected type. [custom_rule] **Severity Level:** Minor ๐งน <details> <summary><b>Why it matters? โญ </b></summary> This new module-level variable is unannotated even though it can be typed for static checking. The custom rule requires type hints on relevant variables in new or modified Python code, so this is a real violation. </details> <details> <summary><b>Rule source ๐ </b></summary> .cursor/rules/dev-standard.mdc (line 28) </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=bbe6ba869b83451eb99ff613a57191be&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=bbe6ba869b83451eb99ff613a57191be&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/utils/legacy_thumbnails.py **Line:** 23:23 **Comment:** *Custom Rule: Add an explicit type annotation for this module-level variable so static type checking can validate its expected type. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41970&comment_hash=74010737c0095bdb69bfaf73ec98ff833632b78943aa7037da2d4e035fec7d4f&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41970&comment_hash=74010737c0095bdb69bfaf73ec98ff833632b78943aa7037da2d4e035fec7d4f&reaction=dislike'>๐</a> ########## tests/unit_tests/utils/legacy_thumbnails_test.py: ########## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from io import BytesIO + +from PIL import Image + +from superset.utils.legacy_thumbnails import generate_thumbnail + +PNG_MAGIC = b"\x89PNG\r\n\x1a\n" Review Comment: **Suggestion:** Add an explicit type annotation to the module-level constant so it complies with the type-hint requirement for relevant variables. [custom_rule] **Severity Level:** Minor ๐งน <details> <summary><b>Why it matters? โญ </b></summary> This new module-level constant is a clearly annotatable Python variable, but it is introduced without an explicit type hint. That matches the rule requiring type hints for relevant variables in new or modified Python code. </details> <details> <summary><b>Rule source ๐ </b></summary> .cursor/rules/dev-standard.mdc (line 28) </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=bce61c4e974e483eac5463c748b8713e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=bce61c4e974e483eac5463c748b8713e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** tests/unit_tests/utils/legacy_thumbnails_test.py **Line:** 23:23 **Comment:** *Custom Rule: Add an explicit type annotation to the module-level constant so it complies with the type-hint requirement for relevant variables. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41970&comment_hash=32cd4b7ccb021df708519448188df5857cdd14bea8cf919a197fb7297bd36263&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41970&comment_hash=32cd4b7ccb021df708519448188df5857cdd14bea8cf919a197fb7297bd36263&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
