rusackas commented on PR #40463: URL: https://github.com/apache/superset/pull/40463#issuecomment-4949825357
@sadpandajoe you're right to flag this — the hardcoded URL isn't the way to go. Turns out this can be resolved without a code change here: master already fixed this exact broken link back in October 2024 (`fix: Link Checking` #30659), using a relative link (`/docs/docs/installation/docker-builds.mdx#build-presets`) rather than a hardcoded one. This branch is quite far behind master at this point (~5,300 commits), and once rebased, this specific line's diff would disappear entirely since master's current version is already the correct fix. Given the PR's remaining diff (relative to current master) is just this one now-superseded line, I'd suggest closing this one out — happy to reopen/help rebase if there's other content in here worth salvaging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
