rusackas commented on PR #41127: URL: https://github.com/apache/superset/pull/41127#issuecomment-4949830348
@richardfogaca good catch, thanks. Fixed: when `MUTATE_AFTER_SPLIT=False` and the engine splits statements individually, we now mutate the whole un-split query once before splitting, in both `sql_lab.py` and `celery_task.py`, with tests covering both flag values across both engine modes. Left the function-local import in `test_executor.py` alone. The rest of that file already imports `execute_sql_with_cursor` locally in four other tests, so moving just mine to module scope would be the odd one out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
