rusackas commented on code in PR #41184:
URL: https://github.com/apache/superset/pull/41184#discussion_r3565630469
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.tsx:
##########
@@ -94,7 +94,6 @@ interface SubtotalOptions {
interface TableRendererProps {
cols: string[];
rows: string[];
- aggregatorName: string;
tableOptions?: TableOptions;
Review Comment:
This is deliberate, not a bypass: the per-metric "Aggregation function"
control is removed by this PR since totals are now DB-computed per metric
definition rather than a single client-chosen function, see UPDATING.md. `Total
(%(aggregatorName)s)` no longer makes sense without it.
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.tsx:
##########
@@ -1099,9 +1096,7 @@ export function TableRenderer(props: TableRendererProps) {
true,
)}
>
- {t('Total (%(aggregatorName)s)', {
- aggregatorName: t(aggregatorName),
- })}
+ {t('Total')}
Review Comment:
Same as the other `aggregatorName` threads on this file, this is intentional
per UPDATING.md since the Aggregation function control is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
