codeant-ai-for-open-source[bot] commented on code in PR #41980:
URL: https://github.com/apache/superset/pull/41980#discussion_r3566980960
##########
superset/migrations/versions/2020-01-08_01-17_e96dbf2cfef0_datasource_cluster_fk.py:
##########
@@ -45,8 +45,8 @@ def upgrade():
# Update cluster_id values
metadata = sa.MetaData(bind=bind)
- datasources = sa.Table("datasources", metadata, autoload=True)
- clusters = sa.Table("clusters", metadata, autoload=True)
+ datasources = sa.Table("datasources", metadata, autoload_with=bind)
Review Comment:
**Suggestion:** Add an explicit type annotation for this reflected table
variable so the new migration code keeps type hints on annotatable variables.
[custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The migration adds a new local variable without a type annotation, and the
custom rule explicitly requires type hints for annotatable Python variables in
modified code.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=38d5dbea1a214f1288a6c97c35d9223f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=38d5dbea1a214f1288a6c97c35d9223f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset/migrations/versions/2020-01-08_01-17_e96dbf2cfef0_datasource_cluster_fk.py
**Line:** 48:48
**Comment:**
*Custom Rule: Add an explicit type annotation for this reflected table
variable so the new migration code keeps type hints on annotatable variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=4242d68e676a3858078d1630753e801855e9a0cb4d2cea7699c58ef0a68c74f3&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=4242d68e676a3858078d1630753e801855e9a0cb4d2cea7699c58ef0a68c74f3&reaction=dislike'>๐</a>
##########
superset/migrations/versions/2020-01-08_01-17_e96dbf2cfef0_datasource_cluster_fk.py:
##########
@@ -87,8 +87,8 @@ def downgrade():
# Update cluster_name values
metadata = sa.MetaData(bind=bind)
- datasources = sa.Table("datasources", metadata, autoload=True)
- clusters = sa.Table("clusters", metadata, autoload=True)
+ datasources = sa.Table("datasources", metadata, autoload_with=bind)
+ clusters = sa.Table("clusters", metadata, autoload_with=bind)
Review Comment:
**Suggestion:** Add an explicit type annotation for this reflected table
variable in the downgrade code to satisfy the custom type-hint rule.
[custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The added reflected table assignment is also unannotated, so it falls under
the custom rule requiring type hints for relevant variables.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0e8866ea137e43c1b7ba6db95faca2f1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0e8866ea137e43c1b7ba6db95faca2f1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset/migrations/versions/2020-01-08_01-17_e96dbf2cfef0_datasource_cluster_fk.py
**Line:** 91:91
**Comment:**
*Custom Rule: Add an explicit type annotation for this reflected table
variable in the downgrade code to satisfy the custom type-hint rule.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=e290c25aa112f826cf792ff789a9aa578c2cbee1d76ef315b9be7420360571dd&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=e290c25aa112f826cf792ff789a9aa578c2cbee1d76ef315b9be7420360571dd&reaction=dislike'>๐</a>
##########
superset/migrations/versions/2020-01-08_01-17_e96dbf2cfef0_datasource_cluster_fk.py:
##########
@@ -87,8 +87,8 @@ def downgrade():
# Update cluster_name values
metadata = sa.MetaData(bind=bind)
- datasources = sa.Table("datasources", metadata, autoload=True)
- clusters = sa.Table("clusters", metadata, autoload=True)
+ datasources = sa.Table("datasources", metadata, autoload_with=bind)
Review Comment:
**Suggestion:** Add an explicit type annotation for this reflected table
variable in the downgrade path as well for consistency with type-hinting rules.
[custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This downgraded path also introduces an unannotated local variable in
modified Python code, matching the type-hint rule violation.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b800efd299e34108aa72c134eef20883&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b800efd299e34108aa72c134eef20883&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset/migrations/versions/2020-01-08_01-17_e96dbf2cfef0_datasource_cluster_fk.py
**Line:** 90:90
**Comment:**
*Custom Rule: Add an explicit type annotation for this reflected table
variable in the downgrade path as well for consistency with type-hinting rules.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=38323d271492397763f715ac7f14b1ef4b6e62cc68000ab6358d18d44ec1fc24&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=38323d271492397763f715ac7f14b1ef4b6e62cc68000ab6358d18d44ec1fc24&reaction=dislike'>๐</a>
##########
superset/migrations/versions/2020-04-24_10-46_e557699a813e_add_tables_relation_to_row_level_.py:
##########
@@ -48,7 +48,7 @@ def upgrade():
sa.PrimaryKeyConstraint("id"),
)
- rlsf = sa.Table("row_level_security_filters", metadata, autoload=True)
+ rlsf = sa.Table("row_level_security_filters", metadata, autoload_with=bind)
Review Comment:
**Suggestion:** Add an explicit type annotation for this newly introduced
reflected table variable. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This newly added Python variable is assigned a SQLAlchemy table object
without any type annotation, which matches the type-hint rule for annotatable
variables.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ee2bebd55d444d9492000580c5ae0da4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ee2bebd55d444d9492000580c5ae0da4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset/migrations/versions/2020-04-24_10-46_e557699a813e_add_tables_relation_to_row_level_.py
**Line:** 51:51
**Comment:**
*Custom Rule: Add an explicit type annotation for this newly introduced
reflected table variable.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=5d386fa33b36e737e75813f5e01acb1849e08e2aa3fb2906b52c74b46b7b65c0&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=5d386fa33b36e737e75813f5e01acb1849e08e2aa3fb2906b52c74b46b7b65c0&reaction=dislike'>๐</a>
##########
superset/migrations/versions/2020-09-15_18-22_e5ef6828ac4e_add_rls_filter_type_and_grouping_key.py:
##########
@@ -44,7 +44,7 @@ def upgrade():
bind = op.get_bind()
metadata = sa.MetaData(bind=bind)
- filters = sa.Table("row_level_security_filters", metadata, autoload=True)
+ filters = sa.Table("row_level_security_filters", metadata,
autoload_with=bind)
Review Comment:
**Suggestion:** Add an explicit type annotation for this newly introduced
SQLAlchemy table variable to comply with the type-hint requirement.
[custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The new local variable `filters` is introduced without a type annotation,
and it is a Python variable whose type can be annotated. This matches the rule
requiring type hints on new or modified Python code where applicable.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=481f836cdebe478b80420f2453a1b79c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=481f836cdebe478b80420f2453a1b79c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset/migrations/versions/2020-09-15_18-22_e5ef6828ac4e_add_rls_filter_type_and_grouping_key.py
**Line:** 47:47
**Comment:**
*Custom Rule: Add an explicit type annotation for this newly introduced
SQLAlchemy table variable to comply with the type-hint requirement.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=6a6c3dce4be528586b1a9be3921b944ddf505d06ac5469a0e577bc619d30f388&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=6a6c3dce4be528586b1a9be3921b944ddf505d06ac5469a0e577bc619d30f388&reaction=dislike'>๐</a>
##########
superset/utils/core.py:
##########
@@ -641,9 +641,7 @@ def generic_find_constraint_name(
table: str, columns: set[str], referenced: str, database: SQLAlchemy
) -> str | None:
"""Utility to find a constraint name in alembic migrations"""
- tbl = sa.Table(
- table, database.metadata, autoload=True, autoload_with=database.engine
- )
+ tbl = sa.Table(table, database.metadata, autoload_with=database.engine)
Review Comment:
**Suggestion:** Add an explicit type annotation for this new local table
variable to satisfy the type-hint requirement for relevant variables.
[custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The new local variable `tbl` is introduced without an explicit type
annotation, and the rule requires type hints on relevant variables that can be
annotated. This is a real violation in the modified code.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4dd2c0105d824b67bfc226007727a34c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4dd2c0105d824b67bfc226007727a34c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/utils/core.py
**Line:** 644:644
**Comment:**
*Custom Rule: Add an explicit type annotation for this new local table
variable to satisfy the type-hint requirement for relevant variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=132e3a18be802010660ccd1b66f26265711a92be100e3bf4823b1de83bf3e9b1&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=132e3a18be802010660ccd1b66f26265711a92be100e3bf4823b1de83bf3e9b1&reaction=dislike'>๐</a>
##########
superset/migrations/versions/2020-04-24_10-46_e557699a813e_add_tables_relation_to_row_level_.py:
##########
@@ -81,9 +81,9 @@ def downgrade():
),
)
- rlsf = sa.Table("row_level_security_filters", metadata, autoload=True)
- rls_filter_tables = sa.Table("rls_filter_tables", metadata, autoload=True)
- rls_filter_roles = sa.Table("rls_filter_roles", metadata, autoload=True)
+ rlsf = sa.Table("row_level_security_filters", metadata, autoload_with=bind)
+ rls_filter_tables = sa.Table("rls_filter_tables", metadata,
autoload_with=bind)
+ rls_filter_roles = sa.Table("rls_filter_roles", metadata,
autoload_with=bind)
Review Comment:
**Suggestion:** Add an explicit type annotation for this newly introduced
reflected table variable. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This is a newly introduced local variable in modified Python code, and it
lacks an explicit type hint despite being annotatable.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c15f4a493623456fbc5959a9dc98be17&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c15f4a493623456fbc5959a9dc98be17&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset/migrations/versions/2020-04-24_10-46_e557699a813e_add_tables_relation_to_row_level_.py
**Line:** 86:86
**Comment:**
*Custom Rule: Add an explicit type annotation for this newly introduced
reflected table variable.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=643dcfeee5556dc5909ba49bc70647487ccd5ec9349860e7d15ae539d012db6f&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=643dcfeee5556dc5909ba49bc70647487ccd5ec9349860e7d15ae539d012db6f&reaction=dislike'>๐</a>
##########
superset/migrations/versions/2020-04-24_10-46_e557699a813e_add_tables_relation_to_row_level_.py:
##########
@@ -81,9 +81,9 @@ def downgrade():
),
)
- rlsf = sa.Table("row_level_security_filters", metadata, autoload=True)
- rls_filter_tables = sa.Table("rls_filter_tables", metadata, autoload=True)
- rls_filter_roles = sa.Table("rls_filter_roles", metadata, autoload=True)
+ rlsf = sa.Table("row_level_security_filters", metadata, autoload_with=bind)
+ rls_filter_tables = sa.Table("rls_filter_tables", metadata,
autoload_with=bind)
Review Comment:
**Suggestion:** Add an explicit type annotation for this newly introduced
reflected table variable. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This added local variable is a reflected SQLAlchemy table and has no type
annotation, so it falls under the Python type-hint requirement for newly
modified code.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=dbde1f79f41f4de381fe2cb851f2a000&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=dbde1f79f41f4de381fe2cb851f2a000&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset/migrations/versions/2020-04-24_10-46_e557699a813e_add_tables_relation_to_row_level_.py
**Line:** 85:85
**Comment:**
*Custom Rule: Add an explicit type annotation for this newly introduced
reflected table variable.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=4a89a6e8fb18f7c279a19fecf2fa800fd5d356e93ca1c0a21eba56416d3a6402&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41980&comment_hash=4a89a6e8fb18f7c279a19fecf2fa800fd5d356e93ca1c0a21eba56416d3a6402&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
