bito-code-review[bot] commented on PR #41994:
URL: https://github.com/apache/superset/pull/41994#issuecomment-4955869354
<!-- Bito Reply -->
The suggestion to add an explicit type annotation to the ORM field is
correct, as it improves static type safety for the model attribute. You can
resolve this by adding the appropriate type hint (e.g., `Column[int]`) to the
field definition.
Example fix:
```python
created_by_fk: Column[int] = Column(
Integer, ForeignKey("ab_user.id", ondelete="SET NULL"), nullable=True
)
```
There are no other comments on this PR. Would you like me to check for any
other potential improvements or address other areas of the code?
**superset/models/sql_lab.py**
```
created_by_fk: Column[int] = Column(
Integer, ForeignKey("ab_user.id", ondelete="SET NULL"), nullable=True
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
