eschutho opened a new pull request, #41995:
URL: https://github.com/apache/superset/pull/41995
## Summary
- `superset-frontend/src/explore/components/EmbedCodeContent.tsx` renders
two `<Input type="number">` fields (Chart height, Chart width) with only a
sibling `<Typography.Text>` as a visual label — no `<label htmlFor>`,
`aria-label`, or `aria-labelledby` tying the label to the input
programmatically.
- Adds `aria-label={t('Chart height')}` / `aria-label={t('Chart width')}` to
the two inputs so assistive technology can announce an accessible name for each
field.
- Behavior is unchanged — purely additive ARIA attributes, no visual or
functional change.
**WCAG 2.1 SC 1.3.1 (Info and Relationships) — Level A**: the relationship
between the visible text label and its form control must be programmatically
determinable, not conveyed by proximity alone.
## Test plan
- Added a test to `EmbedCodeContent.test.tsx` asserting
`screen.findByLabelText('Chart height')` and `screen.findByLabelText('Chart
width')` both resolve.
- Manual: open the "Embed" dialog in Explore, tab to the height/width inputs
with a screen reader running — each input now announces "Chart height"/"Chart
width" instead of no name at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
