massucattoj opened a new pull request, #41997: URL: https://github.com/apache/superset/pull/41997
### SUMMARY Adds subdirectory (`SUPERSET_APP_ROOT`) regression coverage for the "Add an annotation layer here" link shown in the annotation layer chart selector when the search finds no results. Under a subdirectory deployment this link used to point to the un-prefixed `/annotationlayer/list` and 404'd. It was fixed as part of #33508 (which routed this href through `ensureAppRoot`) and later refactored by #39925, but no test pinned the behavior, so either historical regression path (dropping `ensureAppRoot`, or hardcoding a prefix) would ship silently. The new test mocks `applicationRoot()` as `/superset` (same seam as `Menu.subdirectory.test.tsx`), renders the real component, and asserts the anchor's href is `/superset/annotationlayer/list`. Verified the test fails when `ensureAppRoot` is removed from the link. ### TESTING INSTRUCTIONS `npm run test -- src/explore/components/controls/AnnotationLayerControl/` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
