codeant-ai-for-open-source[bot] commented on code in PR #41999: URL: https://github.com/apache/superset/pull/41999#discussion_r3570779855
########## superset-frontend/playwright/tests/dashboard/delete-display-control.spec.ts: ########## @@ -0,0 +1,262 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * Regression test: a deleted Display Control (chart customization) must not + * reappear after clicking "Apply Filters". Seeds a dashboard with a Gender + * filter and a Time grain Display Control, deletes the control via the config + * modal, then applies and asserts it stays gone. + */ +import { testWithAssets, expect } from '../../helpers/fixtures'; +import { apiPost, apiPut } from '../../helpers/api/requests'; +import { apiPostDashboard } from '../../helpers/api/dashboard'; +import { DashboardPage } from '../../pages/DashboardPage'; + +// Record video regardless of pass/fail (before/after clips). +testWithAssets.use({ video: 'on' }); + +const DATASET_NAME = 'birth_names'; +const FILTER_COLUMN = 'gender'; +const TEMPORAL_COLUMN = 'ds'; + +async function findDatasetIdByName(page: any, name: string): Promise<number> { Review Comment: **Suggestion:** Replace the `any` parameter type with a concrete Playwright page type to preserve type safety in this helper. [custom_rule] **Severity Level:** Minor ๐งน <details> <summary><b>Why it matters? โญ </b></summary> The rule forbids new or changed TypeScript code from using `any`. This helper declares `page: any`, so the suggestion correctly identifies a real violation in the added test file. </details> <details> <summary><b>Rule source ๐ </b></summary> .cursor/rules/dev-standard.mdc (line 16) </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4ce276c3a08a4b96a67a40e700c8745f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4ce276c3a08a4b96a67a40e700c8745f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset-frontend/playwright/tests/dashboard/delete-display-control.spec.ts **Line:** 38:38 **Comment:** *Custom Rule: Replace the `any` parameter type with a concrete Playwright page type to preserve type safety in this helper. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41999&comment_hash=8f9cc89bfd1cf280547b35f924d33d81809ee79b85c9501085f9777675713300&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41999&comment_hash=8f9cc89bfd1cf280547b35f924d33d81809ee79b85c9501085f9777675713300&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
