innovark37 commented on code in PR #40885:
URL: https://github.com/apache/superset/pull/40885#discussion_r3571249998
##########
superset/charts/client_processing.py:
##########
@@ -357,6 +357,13 @@ def apply_client_processing( # noqa: C901
sep=sep,
decimal=decimal,
)
+ elif query["result_format"] == ChartDataResultFormat.XLSX:
+ read_excel_kwargs = (
+ {"index_col": 0}
+ if current_app.config["EXCEL_EXPORT"].get("index", True)
+ else {}
+ )
+ df = pd.read_excel(BytesIO(data), **read_excel_kwargs)
Review Comment:
Fixed.
The XLSX reader no longer uses `EXCEL_EXPORT["index"]` to decide whether to
consume the first column as an index. It now reads the payload first and
derives index handling from the XLSX structure plus the expected
columns/metrics from `form_data`, so XLSX files exported without an index keep
their first real data column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
