codeant-ai-for-open-source[bot] commented on code in PR #38910:
URL: https://github.com/apache/superset/pull/38910#discussion_r3571741976
##########
tests/integration_tests/charts/data/api_tests.py:
##########
@@ -1679,6 +1679,164 @@ def test_data_cache_default_timeout(
assert rv.json["result"][0]["cache_timeout"] == 3456
+def _native_filter_options_config(
+ native_filter_timeout: int | None = None,
+ data_cache_timeout: int = 3456,
+) -> dict[str, Any]:
+ """
+ Build a patched config for native filter option cache timeout tests.
+ """
+ config = {
+ **app.config,
+ "CACHE_DEFAULT_TIMEOUT": 100_000,
+ "DATA_CACHE_CONFIG": {
+ **app.config["DATA_CACHE_CONFIG"],
+ "CACHE_DEFAULT_TIMEOUT": data_cache_timeout,
+ },
+ }
+ if native_filter_timeout is not None:
+ config["NATIVE_FILTER_OPTIONS_CACHE_TIMEOUT"] = native_filter_timeout
+ else:
+ config.pop("NATIVE_FILTER_OPTIONS_CACHE_TIMEOUT", None)
+ return config
+
+
+_NATIVE_FILTER_SELECT_FORM_DATA: dict[str, Any] = {
+ "native_filter_id": "NATIVE_FILTER-abc123",
+ "viz_type": "filter_select",
+ "metrics": ["count"], # CRITICAL โ always present in real requests
+ "groupby": ["col1"],
+ "row_limit": 1000,
+}
+
+
[email protected](
+ "superset.common.query_context_processor.current_app.config",
+ _native_filter_options_config(native_filter_timeout=None,
data_cache_timeout=3456),
+)
+def test_native_filter_default_uses_data_cache_timeout(
+ test_client,
+ login_as_admin,
+ physical_query_context,
Review Comment:
**Suggestion:** Add type annotations for each fixture parameter and include
an explicit <code>-> None</code> return annotation on this new test function.
[custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This is newly added Python test code and the function parameters are
unannotated, with no explicit return type. That violates the Python type-hint
requirement for modified/new code.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=644043459eaa46ad9ecd0451fdb9fbe8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=644043459eaa46ad9ecd0451fdb9fbe8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/charts/data/api_tests.py
**Line:** 1717:1720
**Comment:**
*Custom Rule: Add type annotations for each fixture parameter and
include an explicit <code>-> None</code> return annotation on this new test
function.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38910&comment_hash=7a522b79a062ef6fe859d127cae4368279fde1981678bdc360089b937c7eba7a&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38910&comment_hash=7a522b79a062ef6fe859d127cae4368279fde1981678bdc360089b937c7eba7a&reaction=dislike'>๐</a>
##########
tests/integration_tests/charts/data/api_tests.py:
##########
@@ -1679,6 +1679,164 @@ def test_data_cache_default_timeout(
assert rv.json["result"][0]["cache_timeout"] == 3456
+def _native_filter_options_config(
+ native_filter_timeout: int | None = None,
+ data_cache_timeout: int = 3456,
+) -> dict[str, Any]:
+ """
+ Build a patched config for native filter option cache timeout tests.
+ """
+ config = {
+ **app.config,
+ "CACHE_DEFAULT_TIMEOUT": 100_000,
+ "DATA_CACHE_CONFIG": {
+ **app.config["DATA_CACHE_CONFIG"],
+ "CACHE_DEFAULT_TIMEOUT": data_cache_timeout,
+ },
+ }
+ if native_filter_timeout is not None:
+ config["NATIVE_FILTER_OPTIONS_CACHE_TIMEOUT"] = native_filter_timeout
+ else:
+ config.pop("NATIVE_FILTER_OPTIONS_CACHE_TIMEOUT", None)
+ return config
+
+
+_NATIVE_FILTER_SELECT_FORM_DATA: dict[str, Any] = {
+ "native_filter_id": "NATIVE_FILTER-abc123",
+ "viz_type": "filter_select",
+ "metrics": ["count"], # CRITICAL โ always present in real requests
+ "groupby": ["col1"],
+ "row_limit": 1000,
+}
+
+
[email protected](
+ "superset.common.query_context_processor.current_app.config",
+ _native_filter_options_config(native_filter_timeout=None,
data_cache_timeout=3456),
+)
+def test_native_filter_default_uses_data_cache_timeout(
+ test_client,
+ login_as_admin,
+ physical_query_context,
+):
+ physical_query_context["form_data"] =
copy.deepcopy(_NATIVE_FILTER_SELECT_FORM_DATA)
+ rv = test_client.post(CHART_DATA_URI, json=physical_query_context)
+ assert rv.json["result"][0]["cache_timeout"] == 3456
+
+
[email protected](
+ "superset.common.query_context_processor.current_app.config",
+ _native_filter_options_config(native_filter_timeout=9999,
data_cache_timeout=3456),
+)
+def test_native_filter_uses_native_filter_options_cache_timeout(
+ test_client,
+ login_as_admin,
+ physical_query_context,
Review Comment:
**Suggestion:** Add explicit parameter type hints and a <code>-> None</code>
return type to this newly introduced test function. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This added test function omits parameter type hints and a return annotation,
which is exactly the kind of new Python code the rule flags.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=eec4a72644784387a0c3be99cbe7fde9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=eec4a72644784387a0c3be99cbe7fde9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/charts/data/api_tests.py
**Line:** 1731:1734
**Comment:**
*Custom Rule: Add explicit parameter type hints and a <code>->
None</code> return type to this newly introduced test function.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38910&comment_hash=b9f542bc3f5ba4d1b06e8a61cc1d6b1cf7a428ffe320090611ebf11773d6ee9f&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38910&comment_hash=b9f542bc3f5ba4d1b06e8a61cc1d6b1cf7a428ffe320090611ebf11773d6ee9f&reaction=dislike'>๐</a>
##########
tests/integration_tests/charts/data/api_tests.py:
##########
@@ -1679,6 +1679,164 @@ def test_data_cache_default_timeout(
assert rv.json["result"][0]["cache_timeout"] == 3456
+def _native_filter_options_config(
+ native_filter_timeout: int | None = None,
+ data_cache_timeout: int = 3456,
+) -> dict[str, Any]:
+ """
+ Build a patched config for native filter option cache timeout tests.
+ """
+ config = {
+ **app.config,
+ "CACHE_DEFAULT_TIMEOUT": 100_000,
+ "DATA_CACHE_CONFIG": {
+ **app.config["DATA_CACHE_CONFIG"],
+ "CACHE_DEFAULT_TIMEOUT": data_cache_timeout,
+ },
+ }
+ if native_filter_timeout is not None:
+ config["NATIVE_FILTER_OPTIONS_CACHE_TIMEOUT"] = native_filter_timeout
+ else:
+ config.pop("NATIVE_FILTER_OPTIONS_CACHE_TIMEOUT", None)
+ return config
+
+
+_NATIVE_FILTER_SELECT_FORM_DATA: dict[str, Any] = {
+ "native_filter_id": "NATIVE_FILTER-abc123",
+ "viz_type": "filter_select",
+ "metrics": ["count"], # CRITICAL โ always present in real requests
+ "groupby": ["col1"],
+ "row_limit": 1000,
+}
+
+
[email protected](
+ "superset.common.query_context_processor.current_app.config",
+ _native_filter_options_config(native_filter_timeout=None,
data_cache_timeout=3456),
+)
+def test_native_filter_default_uses_data_cache_timeout(
+ test_client,
+ login_as_admin,
+ physical_query_context,
+):
+ physical_query_context["form_data"] =
copy.deepcopy(_NATIVE_FILTER_SELECT_FORM_DATA)
+ rv = test_client.post(CHART_DATA_URI, json=physical_query_context)
+ assert rv.json["result"][0]["cache_timeout"] == 3456
+
+
[email protected](
+ "superset.common.query_context_processor.current_app.config",
+ _native_filter_options_config(native_filter_timeout=9999,
data_cache_timeout=3456),
+)
+def test_native_filter_uses_native_filter_options_cache_timeout(
+ test_client,
+ login_as_admin,
+ physical_query_context,
+):
+ physical_query_context["form_data"] =
copy.deepcopy(_NATIVE_FILTER_SELECT_FORM_DATA)
+ rv = test_client.post(CHART_DATA_URI, json=physical_query_context)
+ assert rv.json["result"][0]["cache_timeout"] == 9999
+
+
[email protected](
+ "superset.common.query_context_processor.current_app.config",
+ _native_filter_options_config(native_filter_timeout=300,
data_cache_timeout=3456),
+)
+def test_native_filter_overrides_dataset_timeout(
+ test_client,
+ login_as_admin,
+ physical_query_context,
Review Comment:
**Suggestion:** Annotate all function parameters with concrete types and add
a <code>-> None</code> return annotation for this test. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This is a newly introduced Python function with untyped parameters and no
explicit return type, so it violates the type-hint rule.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0e87aa6e81454ab4a4770b3103461b95&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0e87aa6e81454ab4a4770b3103461b95&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/charts/data/api_tests.py
**Line:** 1745:1748
**Comment:**
*Custom Rule: Annotate all function parameters with concrete types and
add a <code>-> None</code> return annotation for this test.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38910&comment_hash=a3afe26606f0b82ec02a2c37032287cfd0dd0ebd65b0144b6915b4dc2890c663&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38910&comment_hash=a3afe26606f0b82ec02a2c37032287cfd0dd0ebd65b0144b6915b4dc2890c663&reaction=dislike'>๐</a>
##########
tests/integration_tests/charts/data/api_tests.py:
##########
@@ -1679,6 +1679,164 @@ def test_data_cache_default_timeout(
assert rv.json["result"][0]["cache_timeout"] == 3456
+def _native_filter_options_config(
+ native_filter_timeout: int | None = None,
+ data_cache_timeout: int = 3456,
+) -> dict[str, Any]:
+ """
+ Build a patched config for native filter option cache timeout tests.
+ """
+ config = {
+ **app.config,
+ "CACHE_DEFAULT_TIMEOUT": 100_000,
+ "DATA_CACHE_CONFIG": {
+ **app.config["DATA_CACHE_CONFIG"],
+ "CACHE_DEFAULT_TIMEOUT": data_cache_timeout,
+ },
+ }
+ if native_filter_timeout is not None:
+ config["NATIVE_FILTER_OPTIONS_CACHE_TIMEOUT"] = native_filter_timeout
+ else:
+ config.pop("NATIVE_FILTER_OPTIONS_CACHE_TIMEOUT", None)
+ return config
+
+
+_NATIVE_FILTER_SELECT_FORM_DATA: dict[str, Any] = {
+ "native_filter_id": "NATIVE_FILTER-abc123",
+ "viz_type": "filter_select",
+ "metrics": ["count"], # CRITICAL โ always present in real requests
+ "groupby": ["col1"],
+ "row_limit": 1000,
+}
+
+
[email protected](
+ "superset.common.query_context_processor.current_app.config",
+ _native_filter_options_config(native_filter_timeout=None,
data_cache_timeout=3456),
+)
+def test_native_filter_default_uses_data_cache_timeout(
+ test_client,
+ login_as_admin,
+ physical_query_context,
+):
+ physical_query_context["form_data"] =
copy.deepcopy(_NATIVE_FILTER_SELECT_FORM_DATA)
+ rv = test_client.post(CHART_DATA_URI, json=physical_query_context)
+ assert rv.json["result"][0]["cache_timeout"] == 3456
+
+
[email protected](
+ "superset.common.query_context_processor.current_app.config",
+ _native_filter_options_config(native_filter_timeout=9999,
data_cache_timeout=3456),
+)
+def test_native_filter_uses_native_filter_options_cache_timeout(
+ test_client,
+ login_as_admin,
+ physical_query_context,
+):
+ physical_query_context["form_data"] =
copy.deepcopy(_NATIVE_FILTER_SELECT_FORM_DATA)
+ rv = test_client.post(CHART_DATA_URI, json=physical_query_context)
+ assert rv.json["result"][0]["cache_timeout"] == 9999
+
+
[email protected](
+ "superset.common.query_context_processor.current_app.config",
+ _native_filter_options_config(native_filter_timeout=300,
data_cache_timeout=3456),
+)
+def test_native_filter_overrides_dataset_timeout(
+ test_client,
+ login_as_admin,
+ physical_query_context,
+):
+ datasource: SqlaTable = (
+ db.session.query(SqlaTable)
+ .filter(SqlaTable.id == physical_query_context["datasource"]["id"])
+ .first()
+ )
+ datasource.cache_timeout = 86400
+ db.session.commit()
+
+ physical_query_context["form_data"] =
copy.deepcopy(_NATIVE_FILTER_SELECT_FORM_DATA)
+ rv = test_client.post(CHART_DATA_URI, json=physical_query_context)
+ assert rv.json["result"][0]["cache_timeout"] == 300
+
+
[email protected](
+ "superset.common.query_context_processor.current_app.config",
+ _native_filter_options_config(native_filter_timeout=300,
data_cache_timeout=3456),
+)
+def test_standard_chart_uses_dataset_timeout(
+ test_client,
+ login_as_admin,
+ physical_query_context,
+):
+ datasource: SqlaTable = (
+ db.session.query(SqlaTable)
+ .filter(SqlaTable.id == physical_query_context["datasource"]["id"])
+ .first()
+ )
+ datasource.cache_timeout = 86400
+ db.session.commit()
+
+ physical_query_context["form_data"] = {
+ "viz_type": "bar",
+ "metrics": ["count"],
+ "groupby": ["col1"],
+ }
+ rv = test_client.post(CHART_DATA_URI, json=physical_query_context)
+ assert rv.json["result"][0]["cache_timeout"] == 86400
+
+
[email protected](
+ "superset.common.query_context_processor.current_app.config",
+ _native_filter_options_config(
+ native_filter_timeout=CACHE_DISABLED_TIMEOUT, data_cache_timeout=3456
+ ),
+)
+def test_native_filter_cache_disabled_semantics(
+ test_client,
+ login_as_admin,
+ physical_query_context,
Review Comment:
**Suggestion:** Provide explicit type hints for the parameters and add a
<code>-> None</code> return annotation for this new test function. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This newly added function omits type hints for its parameters and return
type, so it matches the custom rule violation.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5ccba0d17c7f479fb30e9b1e63e47d87&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5ccba0d17c7f479fb30e9b1e63e47d87&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/charts/data/api_tests.py
**Line:** 1795:1798
**Comment:**
*Custom Rule: Provide explicit type hints for the parameters and add a
<code>-> None</code> return annotation for this new test function.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38910&comment_hash=2238f94d9335af369a4aab651446631c356662a7e13f69676ae0c32f2abeaf7f&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38910&comment_hash=2238f94d9335af369a4aab651446631c356662a7e13f69676ae0c32f2abeaf7f&reaction=dislike'>๐</a>
##########
tests/integration_tests/charts/data/api_tests.py:
##########
@@ -1679,6 +1679,164 @@ def test_data_cache_default_timeout(
assert rv.json["result"][0]["cache_timeout"] == 3456
+def _native_filter_options_config(
+ native_filter_timeout: int | None = None,
+ data_cache_timeout: int = 3456,
+) -> dict[str, Any]:
+ """
+ Build a patched config for native filter option cache timeout tests.
+ """
+ config = {
+ **app.config,
+ "CACHE_DEFAULT_TIMEOUT": 100_000,
+ "DATA_CACHE_CONFIG": {
+ **app.config["DATA_CACHE_CONFIG"],
+ "CACHE_DEFAULT_TIMEOUT": data_cache_timeout,
+ },
+ }
+ if native_filter_timeout is not None:
+ config["NATIVE_FILTER_OPTIONS_CACHE_TIMEOUT"] = native_filter_timeout
+ else:
+ config.pop("NATIVE_FILTER_OPTIONS_CACHE_TIMEOUT", None)
+ return config
+
+
+_NATIVE_FILTER_SELECT_FORM_DATA: dict[str, Any] = {
+ "native_filter_id": "NATIVE_FILTER-abc123",
+ "viz_type": "filter_select",
+ "metrics": ["count"], # CRITICAL โ always present in real requests
+ "groupby": ["col1"],
+ "row_limit": 1000,
+}
+
+
[email protected](
+ "superset.common.query_context_processor.current_app.config",
+ _native_filter_options_config(native_filter_timeout=None,
data_cache_timeout=3456),
+)
+def test_native_filter_default_uses_data_cache_timeout(
+ test_client,
+ login_as_admin,
+ physical_query_context,
+):
+ physical_query_context["form_data"] =
copy.deepcopy(_NATIVE_FILTER_SELECT_FORM_DATA)
+ rv = test_client.post(CHART_DATA_URI, json=physical_query_context)
+ assert rv.json["result"][0]["cache_timeout"] == 3456
+
+
[email protected](
+ "superset.common.query_context_processor.current_app.config",
+ _native_filter_options_config(native_filter_timeout=9999,
data_cache_timeout=3456),
+)
+def test_native_filter_uses_native_filter_options_cache_timeout(
+ test_client,
+ login_as_admin,
+ physical_query_context,
+):
+ physical_query_context["form_data"] =
copy.deepcopy(_NATIVE_FILTER_SELECT_FORM_DATA)
+ rv = test_client.post(CHART_DATA_URI, json=physical_query_context)
+ assert rv.json["result"][0]["cache_timeout"] == 9999
+
+
[email protected](
+ "superset.common.query_context_processor.current_app.config",
+ _native_filter_options_config(native_filter_timeout=300,
data_cache_timeout=3456),
+)
+def test_native_filter_overrides_dataset_timeout(
+ test_client,
+ login_as_admin,
+ physical_query_context,
+):
+ datasource: SqlaTable = (
+ db.session.query(SqlaTable)
+ .filter(SqlaTable.id == physical_query_context["datasource"]["id"])
+ .first()
+ )
+ datasource.cache_timeout = 86400
+ db.session.commit()
+
+ physical_query_context["form_data"] =
copy.deepcopy(_NATIVE_FILTER_SELECT_FORM_DATA)
+ rv = test_client.post(CHART_DATA_URI, json=physical_query_context)
+ assert rv.json["result"][0]["cache_timeout"] == 300
+
+
[email protected](
+ "superset.common.query_context_processor.current_app.config",
+ _native_filter_options_config(native_filter_timeout=300,
data_cache_timeout=3456),
+)
+def test_standard_chart_uses_dataset_timeout(
+ test_client,
+ login_as_admin,
+ physical_query_context,
Review Comment:
**Suggestion:** Add type hints for all fixture arguments and specify an
explicit <code>-> None</code> return type on this added function. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This added test function has unannotated parameters and lacks a return
annotation, which is a real violation of the Python type-hint rule.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f52fec922b024785a58f7ba85e538be6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f52fec922b024785a58f7ba85e538be6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/charts/data/api_tests.py
**Line:** 1767:1770
**Comment:**
*Custom Rule: Add type hints for all fixture arguments and specify an
explicit <code>-> None</code> return type on this added function.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38910&comment_hash=9d804dde47da4834a73efc66828f98c87930d19528e9db3594f48a0ad46ce067&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38910&comment_hash=9d804dde47da4834a73efc66828f98c87930d19528e9db3594f48a0ad46ce067&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
