EnxDev opened a new pull request, #42003:
URL: https://github.com/apache/superset/pull/42003

   ### SUMMARY
   Time-shift (time-comparison) line charts intermittently render partially in 
PDF/PNG email reports and thumbnails — the line "breaks off" or the chart is 
blank.
   
   **Root cause:** 
   report screenshots capture the chart while ECharts is still animating.
   
   The screenshot path has no render-complete signal — it just waits a fixed 
timeout, which loses the race under load (and the time-comparison series, drawn 
last, is the first to be cut off). Bumping the timeout only masks it.
   
   **Fix:** 
   disable the ECharts draw animation in report/thumbnail standalone mode 
(`standalone=true` / `3`), reusing the existing `isDashboardRefreshing` 
animation override. 
   Static images don't need animation, so the chart is final before capture. 
Interactive/embed rendering is unchanged.
   
   ### BEFORE/AFTER
   - Before 
   
   <img width="1600" height="1200" alt="partial" 
src="https://github.com/user-attachments/assets/1e9c0193-66cb-47af-a9f1-b94caf77a91b";
 />
   
   - After
   
   <img width="1600" height="1200" alt="fixed_race0" 
src="https://github.com/user-attachments/assets/dbfb46bd-40f4-47f6-8bef-dbeccb8f1f40";
 />
   
   
   ### TESTING INSTRUCTIONS
   - `cd superset-frontend && npm run test -- 
plugins/plugin-chart-echarts/src/components/Echart.test.tsx`
   - Or manually: create a time-shift line chart, add it to a report, send as 
PNG/PDF; the full
     chart (base + shifted series) renders every time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to