bito-code-review[bot] commented on PR #42004:
URL: https://github.com/apache/superset/pull/42004#issuecomment-4960268020
<!-- Bito Reply -->
The suggestion to add an explicit return type annotation to the new test
function is correct and follows standard Python type-hinting practices. You can
resolve this by updating the function signature to include `-> None`.
Here is the corrected function signature:
```python
def test_boxplot_mean_median_no_future_warning() -> None:
"""mean/median must be passed as strings (not np.mean/np.median) to
GroupBy.agg, else pandas raises a FutureWarning. Also verify the values
match a plain pandas groupby, since the string and callable forms could
silently diverge on a future pandas version."""
```
There are no other review comments available in the provided context to
check. Would you like me to proceed with any other tasks?
**tests/unit_tests/pandas_postprocessing/test_boxplot.py**
```
def test_boxplot_mean_median_no_future_warning() -> None:
"""mean/median must be passed as strings (not np.mean/np.median) to
GroupBy.agg, else pandas raises a FutureWarning. Also verify the values
match a plain pandas groupby, since the string and callable forms could
silently diverge on a future pandas version."""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
