rebenitez1802 commented on PR #41491:
URL: https://github.com/apache/superset/pull/41491#issuecomment-4960322960
🟡 Medium — Plugin-failure path gives the user no feedback
In start() (superset-frontend/src/embedded/index.tsx), the new pluginsReady
rejection handler only logs and resets started = false, unlike the sibling
auth-failure branch which calls showFailureMessage(...). If
setupPlugins()/setupCodeOverrides() throws, the user is left with a blank #app
and no indication of failure until a re-handshake arrives — which may never
come automatically. Fix: add a showFailureMessage(t('Something went wrong
loading the dashboard. Check the dev console for details.')) in that handler
for parity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
