rebenitez1802 commented on PR #41960: URL: https://github.com/apache/superset/pull/41960#issuecomment-4960374880
🟡 Medium — Test can’t catch the bug it’s named for test_get_drill_detail_preserves_applied_filters asserts filters survive _get_drill_detail, but that function (superset/common/query_actions.py:227) never reads or mutates query_obj.filter — it shallow-copies (copy.copy) and rewrites only is_timeseries, metrics, post_processing, columns, orderby. Since the copy shares the same filter list object, the assertion is effectively guaranteed to pass and can only fail if someone deliberately adds filter-stripping code here. The PR body concedes green ≠bug reproduced, so this guards a path that was never the source of #28562 (which lives upstream in native-filter propagation / getDrillPayload / the query-context filter merge). Fix: retarget the test at the actual filter-assembly path, or rename/reframe it explicitly as a pass-through characterization test so it isn’t mistaken for a real regression guard. 🟢 Low — Wrong file Added to test_query_actions_currency.py, a currency-detection-specific file; drill-detail tests don’t belong there. Fix: move to a new test_query_actions.py (none exists yet) for discoverability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
