aminghadersohi commented on code in PR #41813:
URL: https://github.com/apache/superset/pull/41813#discussion_r3573255632
##########
.pre-commit-config.yaml:
##########
@@ -31,9 +31,10 @@ repos:
types-simplejson,
types-python-dateutil,
types-requests,
- # types-redis 4.6.0.5 is failing mypy
- # because of https://github.com/python/typeshed/pull/10531
- types-redis==4.6.0.4,
+ # types-redis is unmaintained (frozen at the 4.6.0.x API
+ # surface) now that redis-py ships its own bundled types
Review Comment:
NIT: this comment uses "now that" — repo convention (CLAUDE.md) asks for
timeless comment language (avoid now/currently/today) since these go stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
