sadpandajoe opened a new pull request, #42013: URL: https://github.com/apache/superset/pull/42013
### SUMMARY Fix the two deterministic Playwright failures recurring on master: - Scope the display-control deletion flow with accessibility roles and labels instead of the removed Ant Design 5 `.ant-modal-content` DOM structure. - Navigate to the relative `welcome/` URL so Playwright preserves `APP_PREFIX` in the prefixed E2E lane. CI evidence: - [master root Playwright failure](https://github.com/apache/superset/actions/runs/29277097598/job/86909127637) - [master APP_PREFIX Playwright failure](https://github.com/apache/superset/actions/runs/29277097598/job/86909127599) The separate Python 3.10 `syntaqlite` master failure is already owned by #42007 and is intentionally not duplicated here. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; this changes test selectors and navigation only. ### TESTING INSTRUCTIONS ```bash PATH=/Users/joeli/.nvm/versions/node/v24.16.0/bin:$PATH pre-commit run --files \ superset-frontend/playwright/tests/dashboard/delete-display-control.spec.ts \ superset-frontend/playwright/tests/home/welcome.spec.ts cd superset-frontend npm run playwright:test -- --list \ tests/dashboard/delete-display-control.spec.ts \ tests/home/welcome.spec.ts ``` Both changed-file validation and Playwright test discovery pass. The exact browser tests require the Superset E2E services and should pass in both the normal and `/app/prefix` CI lanes. The required `pre-commit run --all-files` was also executed locally. It reaches unrelated existing checkout-wide failures (mapper-test mypy findings, absent docs dependencies, unbuilt package declarations, and existing Ruff findings); no all-files failure points to either changed file. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
