Antonio-RiveroMartnez commented on PR #42012: URL: https://github.com/apache/superset/pull/42012#issuecomment-4962947235
Good catch on the timer race — the suite-level `beforeEach` starts a polling loop on real timers, and switching to fake timers afterwards can't cancel it (the fake `clearTimeout` doesn't clear a real timer), so it could fire mid-test and skew the call counts on slow runs. Fixed in b0371cb: `init()` now clears any pending polling timeout before the feature-flag early return — which also fixes a small real bug, since re-initializing with the flag disabled previously never stopped an already-running loop — and the backoff tests use that to stop the real-timer loop before enabling fake timers, so every scheduled poll runs on the fake clock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
