sadpandajoe opened a new pull request, #42017:
URL: https://github.com/apache/superset/pull/42017
### SUMMARY
Follow up on #42013 by bringing the remaining Clear All regression flow into
the Playwright page-object/component model:
- add a `DashboardFilterBar` component that composes the existing `Button`
and `Select` primitives and owns the native-filter selectors/actions
- have `DashboardPage` compose and expose the filter bar while preserving
its existing `applyFiltersIfEnabled` API
- keep `clear-all-filters.spec.ts` focused on scenario setup, network
observation, and behavioral assertions
- replace the untyped request listener with Playwright's `Request` type
This centralizes UI knowledge without moving scenario-specific assertions or
API asset setup into page objects.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable; this is a Playwright test-architecture refactor with no
product UI change.
### TESTING INSTRUCTIONS
```bash
pre-commit run --files \
superset-frontend/playwright/components/dashboard/DashboardFilterBar.ts \
superset-frontend/playwright/components/dashboard/index.ts \
superset-frontend/playwright/pages/DashboardPage.ts \
superset-frontend/playwright/tests/dashboard/clear-all-filters.spec.ts
cd superset-frontend
npx playwright test \
playwright/tests/dashboard/clear-all-filters.spec.ts \
playwright/tests/dashboard/delete-display-control.spec.ts \
--list --workers=1
```
Targeted formatting, lint, custom frontend rules, and frontend type-check
pass. The required `pre-commit run --all-files` was also executed; its failures
are unrelated checkout-wide baseline/environment issues (existing mapper-test
mypy errors, absent docs eslint, unbuilt package declarations, and existing
Ruff findings).
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
