codeant-ai-for-open-source[bot] commented on code in PR #41855:
URL: https://github.com/apache/superset/pull/41855#discussion_r3575421023
##########
tests/unit_tests/mcp_service/test_mcp_core.py:
##########
@@ -312,3 +316,70 @@ def test_explicit_title_column_overrides_dao_attribute()
-> None:
)
def test_slugify_handles_edge_cases(identifier: str, expected_slug: str) ->
None:
assert _slugify(identifier) == expected_slug
+
+
+def test_deleted_state_bound_filter_delegates_bound_value() -> None:
+ """The adapter passed to DAO custom_filters must forward the bound
+ deleted_state value โ BaseDAO.list invokes custom filters with
+ ``apply(query, None)``, which the FAB filter would treat as 'live only'."""
+ from unittest.mock import Mock
+
+ from superset.mcp_service.mcp_core import DeletedStateBoundFilter
+
+ inner = Mock()
+ inner.apply.return_value = "filtered-query"
+ bound = DeletedStateBoundFilter(inner, "only", model=Mock)
+
+ assert bound.apply("query", None) == "filtered-query"
+ inner.apply.assert_called_once_with("query", "only")
+
+
+def _build_list_core(
+ deleted_state_filter: type | None = None,
+) -> "ModelListCore[Any]":
+ """Minimal ModelListCore for exercising _build_deleted_state_filter."""
+ from unittest.mock import MagicMock
+
+ from pydantic import BaseModel
+
+ class _Out(BaseModel):
+ pass
+
+ return ModelListCore(
+ dao_class=MagicMock(),
+ output_schema=_Out,
+ item_serializer=lambda obj, cols: None,
Review Comment:
**Suggestion:** Replace the untyped lambda with a typed callable so its
parameters are explicitly annotated. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The new test helper passes an untyped lambda into `ModelListCore` where the
parameters can clearly be annotated. This matches the Python type-hints rule
because the introduced callable omits explicit parameter types.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3c7e686495364914ba024b43faf635c1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3c7e686495364914ba024b43faf635c1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/mcp_service/test_mcp_core.py
**Line:** 351:351
**Comment:**
*Custom Rule: Replace the untyped lambda with a typed callable so its
parameters are explicitly annotated.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41855&comment_hash=b76d09b7f9140580149c8e3d29d274b1a0f162b321c9f9290619886b7dfcc0ff&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41855&comment_hash=b76d09b7f9140580149c8e3d29d274b1a0f162b321c9f9290619886b7dfcc0ff&reaction=dislike'>๐</a>
##########
tests/unit_tests/mcp_service/chart/tool/test_list_charts_deleted_state.py:
##########
@@ -0,0 +1,171 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Unit tests for list_charts ``deleted_state`` trash listing.
+
+The deleted_state param opts the list query into surfacing soft-deleted
+charts: the session-scoped visibility bypass wraps the DAO call, the REST
+``ChartDeletedStateFilter`` (which owns the restore-audience scoping) is
+passed through as a DAO custom filter, and ``deleted_at`` is forced into the
+loaded columns so trashed rows are distinguishable in the response.
+"""
+
+from collections.abc import Iterator
+from datetime import datetime
+from unittest.mock import MagicMock, Mock, patch
+from uuid import UUID
+
+import pytest
+from fastmcp import Client
+from fastmcp.exceptions import ToolError
+
+from superset.mcp_service.app import mcp
+from superset.utils import json
+
+_DAO_LIST = "superset.daos.chart.ChartDAO.list"
Review Comment:
**Suggestion:** Add an explicit type annotation to this module-level
constant so it complies with the type-hint requirement for annotatable
variables. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The module-level constant is introduced without a type annotation even
though it is a clearly annotatable string variable. This matches the Python
type-hint rule for relevant variables in new code.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f3da2634459d4499b993837e9ce85532&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f3da2634459d4499b993837e9ce85532&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
tests/unit_tests/mcp_service/chart/tool/test_list_charts_deleted_state.py
**Line:** 39:39
**Comment:**
*Custom Rule: Add an explicit type annotation to this module-level
constant so it complies with the type-hint requirement for annotatable
variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41855&comment_hash=841dc5d52a43a1cbf4f7e527465013d74b2b992204e6770061acaa96a6019b42&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41855&comment_hash=841dc5d52a43a1cbf4f7e527465013d74b2b992204e6770061acaa96a6019b42&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
