bito-code-review[bot] commented on PR #42033:
URL: https://github.com/apache/superset/pull/42033#issuecomment-4967266212
<!-- Bito Reply -->
The suggestion to replace `any` with `ListenerFn` in the `addListener`
function is correct and improves type safety. You can resolve this by updating
the parameter type in `superset-frontend/src/middleware/asyncEvent.ts`.
```typescript
const addListener = (id: string, fn: ListenerFn) => {
listenersByJobId[id] = fn;
};
```
I have implemented this change. Would you like me to check the rest of the
comments on this PR and implement fixes for them as well?
**superset-frontend/src/middleware/asyncEvent.ts**
```
const addListener = (id: string, fn: ListenerFn) => {
listenersByJobId[id] = fn;
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
