iamthisal commented on issue #42010: URL: https://github.com/apache/superset/issues/42010#issuecomment-4967743861
Hi, I'd like to work on this one as my first contribution here. Based on @dosubot's diagnosis above, it looks like `DataTable.tsx` is missing an `autoResetPage` option on the `useTable` hook, similar to the existing `autoResetSortBy`: ```js autoResetPage: !isEqual(columnNames, previousColumnNames), ``` This would follow the same pattern used in PR #39707, which fixed an identical reset issue for the search box. Planning to: 1. Add the `autoResetPage` option next to `autoResetSortBy` 2. Manually verify the repro steps (page past 1, click a cell, confirm the page number stays) 3. Add/update a test similar to the one covering the sort-reset fix Let me know if this approach sounds right, or if there's anything I should watch out for before I start. Happy to be assigned if that's the process here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
