eschutho opened a new pull request, #42034:
URL: https://github.com/apache/superset/pull/42034
## Summary
The "Tag name" field in the Create/Edit Tag modal correctly wires its
visible label to the input via `htmlFor`/`id` (`tag-name`), but the "Tag
description" field right below it was missing both — the visible `FormLabel`
was not programmatically associated with the `Input`, so screen reader users
had no accessible name for that field.
**WCAG 2.1 Success Criterion 4.1.2 (Name, Role, Value) — Level A.**
## Changes
- `superset-frontend/src/features/tags/TagModal.tsx`: added
`htmlFor="tag-description"` to the `FormLabel` and `id="tag-description"` to
the `Input`, mirroring the existing `tag-name` pattern. Also updated the label
text from "Description" to "Tag description" for parity with the sibling "Tag
name" field, since a generic "Description" is more ambiguous outside the
dialog's visual context (e.g. in a flattened screen-reader forms list).
- `superset-frontend/src/features/tags/TagModal.test.tsx`: added a
regression test asserting the input is reachable via
`screen.findByLabelText('Tag description')`.
Behavior is otherwise unchanged — no visual, layout, or functional changes.
## Test plan
- [x] `npx jest src/features/tags/TagModal.test.tsx` passes (4/4, including
the new test)
- [ ] Tab to the Description field in the Create/Edit Tag modal with a
screen reader active and verify it announces "Tag description" as the
accessible name (previously announced nothing / just the input's placeholder)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
