codeant-ai-for-open-source[bot] commented on code in PR #41804:
URL: https://github.com/apache/superset/pull/41804#discussion_r3578398291
##########
tests/unit_tests/models/helpers_test.py:
##########
@@ -3720,3 +3721,75 @@ def
test_simple_metric_quotes_column_requiring_quoting(database: Database) -> No
assert f"SUM({column_name})" not in rendered, (
f"Column requiring quoting was emitted unquoted: {rendered}"
)
+
+
[email protected](
+ "native_type",
+ ["UUID", "uuid", "Nullable(UUID)"],
+)
[email protected](
+ "op",
+ ["LIKE", "ILIKE", "NOT LIKE", "NOT ILIKE"],
+)
+def test_like_filter_on_uuid_column_casts_to_string(
+ database: Database, native_type: str, op: str
+) -> None:
+ """
+ LIKE-family filters on native UUID columns must cast the column to string.
+
+ UUID columns map to ``GenericDataType.STRING``, so the generic-type guard
+ alone skips the string cast โ but engines such as PostgreSQL and ClickHouse
+ reject LIKE/ILIKE against a raw UUID column (issue #41795: table chart
+ server-pagination search fails with e.g. "Illegal type UUID of argument of
+ function ilike"). The native column type must force the cast.
+ """
+ from superset.connectors.sqla.models import SqlaTable, TableColumn
+
+ table = SqlaTable(
+ database=database,
+ schema=None,
+ table_name="t",
+ columns=[TableColumn(column_name="event_id", type=native_type)],
+ )
+
+ result = table.get_sqla_query(
+ columns=["event_id"],
+ metrics=[],
+ extras={},
+ filter=[{"col": "event_id", "op": op, "val": "abc%"}],
+ granularity=None,
+ is_timeseries=False,
+ orderby=[],
+ )
+ whereclause: ColumnElement = result.sqla_query.whereclause
+ assert any(isinstance(node, Cast) for node in iterate(whereclause)), (
+ f"Expected a Cast node in the filter expression: {whereclause}"
+ )
+
+
+def test_like_filter_on_string_column_does_not_cast(database: Database) ->
None:
+ """
+ LIKE-family filters on plain string columns must not add a redundant cast.
+ """
+ from superset.connectors.sqla.models import SqlaTable, TableColumn
+
+ table = SqlaTable(
+ database=database,
+ schema=None,
+ table_name="t",
+ columns=[TableColumn(column_name="b", type="TEXT")],
+ )
+
+ result = table.get_sqla_query(
+ columns=["b"],
+ metrics=[],
+ extras={},
+ filter=[{"col": "b", "op": "ILIKE", "val": "abc%"}],
+ granularity=None,
+ is_timeseries=False,
+ orderby=[],
+ )
+ whereclause = result.sqla_query.whereclause
Review Comment:
**Suggestion:** Add a type annotation for this newly introduced local
variable to comply with the required type-hint coverage for annotatable
variables. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The new local variable is inferred from `result.sqla_query.whereclause` and
can be annotated, but no type hint is provided. This matches the rule requiring
type hints on annotatable Python variables in modified code.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=674a180694924574acb465702fff3081&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=674a180694924574acb465702fff3081&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/models/helpers_test.py
**Line:** 3792:3792
**Comment:**
*Custom Rule: Add a type annotation for this newly introduced local
variable to comply with the required type-hint coverage for annotatable
variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41804&comment_hash=b0197e5b64917e1a5db606a98ff48e7e13732b28f2b34b2b0c3c1be2036f433b&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41804&comment_hash=b0197e5b64917e1a5db606a98ff48e7e13732b28f2b34b2b0c3c1be2036f433b&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
