rusackas commented on PR #40955: URL: https://github.com/apache/superset/pull/40955#issuecomment-4968516107
Thanks @rebenitez1802, appreciate the dig. On the UUID concern: checked it and it's not reachable today. `DatasourceKey` on the frontend always `parseInt`s the id before it goes into `query_context.datasource`, and the MCP `update_chart` tool clears `query_context` entirely rather than submitting a raw payload with one. So nothing in the codebase currently sends a UUID string through this path, though it'd need a resolve-by-UUID fallback here if that ever changes. Also added a comment clarifying the TypeError/ValueError split for the unparseable-payload case, plus tests for a non-table datasource type and a non-numeric id, since those weren't covered before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
