EnxDev commented on issue #41779: URL: https://github.com/apache/superset/issues/41779#issuecomment-4969602663
Thanks for have reframing this @rusackas, this is shaping up really nicely. I especially like the separation between resolution and lifecycle, and I think the loading story is much clearer now. One question I had while reading is around the lifetime of built-in registrations. The SIP states that built-ins register through side-effect imports wherever the surface renders, and that registration is loader-agnostic. Does that imply that providers are expected to remain registered for the lifetime of the application once their chunk has been evaluated? I suspect that's the intended behavior (especially given the idempotent registration by provider id), but it may be worth making it explicit so the registry contract is completely clear. Otherwise, readers may wonder whether surfaces are expected to unregister their built-ins on unmount or whether registration is a one-time application-level operation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
