oskarhinc commented on a change in pull request #8416: #8415: Prevent the
database password from being exported along with the dashboards
URL:
https://github.com/apache/incubator-superset/pull/8416#discussion_r338012540
##########
File path: superset/utils/core.py
##########
@@ -283,7 +283,7 @@ def __init__(self, *args, **kwargs):
# pylint: disable=E0202
def default(self, o):
try:
- vals = {k: v for k, v in o.__dict__.items() if k !=
"_sa_instance_state"}
+ vals = {k: v for k, v in o.__dict__.items() if k !=
"_sa_instance_state" and k != 'password'}
Review comment:
Right, I'll correct it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
