mikebridge commented on PR #41076: URL: https://github.com/apache/superset/pull/41076#issuecomment-4971280330
Follow-up on the review findings posted above: the blocking correctness items and associated cleanup were addressed in `0d6175e5bd`, `9a855a71c0`, and `ea43cd30a2`. In particular, the updated implementation: - globally merges bounded candidates across entity-ID chunks, preserving the newest records regardless of chunk order and reporting truncation consistently; - bounds self and related history to the current `(id, uuid)` incarnation, preventing history leakage when integer IDs are reused; - resolves historical UUIDs during decoration and redacts records that cannot be matched safely; - handles degenerate shadow rows without turning an activity request into a 500; - bounds name/impact lookups to the page transaction range and includes the smaller documentation/docstring cleanups; - adds regression coverage for later-chunk newer records, current-incarnation clipping, empty untracked related scope, reused-ID redaction, and stable total ordering. I also performed a fresh Docker/PostgreSQL dark-launch verification with `ENABLE_VERSIONING_CAPTURE` absent from the environment (resolved by Superset as `False`). I committed description changes to an existing chart, dashboard, and dataset and confirmed that the saves persisted while all capture tables remained empty: - `slices_version`: 0 - `dashboards_version`: 0 - `tables_version`: 0 - `version_transaction`: 0 - `version_changes`: 0 Authenticated requests to each entity's `/activity/` endpoint also returned `count=0`, an empty `result`, and `truncated=false`. This confirms the feature remains inactive by default while the read endpoints continue to behave normally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
