codeant-ai-for-open-source[bot] commented on code in PR #41127:
URL: https://github.com/apache/superset/pull/41127#discussion_r3581897620
##########
tests/integration_tests/sqllab_tests.py:
##########
@@ -663,6 +663,9 @@ def test_execute_sql_statements(
mock_cursor
)
mock_query.database.db_engine_spec.run_multiple_statements_as_one =
False
+ mock_query.database.mutate_sql_based_on_config.side_effect = (
+ lambda sql_, **kwargs: sql_
+ )
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag inline passthrough lambdas assigned to `side_effect` in test
files, since Python lambdas cannot be type-annotated and this pattern is
acceptable in tests.
**Applied to:**
- `**/test/**`
- `**/tests/**`
- `**/*test*.<ext>`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
tests/integration_tests/sqllab_tests.py:
##########
@@ -763,6 +766,9 @@ def test_execute_sql_statements_ctas(
mock_cursor
)
mock_query.database.db_engine_spec.run_multiple_statements_as_one =
False
+ mock_query.database.mutate_sql_based_on_config.side_effect = (
+ lambda sql_, **kwargs: sql_
+ )
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag inline lambdas assigned to `side_effect` in test files just
for lacking type annotations, especially when they match existing test-suite
patterns.
**Applied to:**
- `**/test/**`
- `**/tests/**`
- `**/*test*.<ext>`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
