sha174n opened a new pull request, #42049:
URL: https://github.com/apache/superset/pull/42049

   ### SUMMARY
   
   The `deck_multi` visualization renders a list of child layers, each bound to 
its own datasource referenced by id in the request (`deck_slices`). This 
applies the standard datasource access check 
(`security_manager.raise_for_access`) to every child layer before it is 
queried, and skips any layer the current user cannot access — so a multi-layer 
chart only returns data from datasources the caller is authorized for, 
consistent with how every other query path is gated.
   
   ### TESTING INSTRUCTIONS
   
   `pytest tests/unit_tests/test_viz_get_df_payload.py`
   
   Adds `test_deck_multi_skips_child_layers_without_datasource_access`: a child 
layer whose datasource the current user cannot access is skipped rather than 
queried.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to