bito-code-review[bot] commented on code in PR #42051:
URL: https://github.com/apache/superset/pull/42051#discussion_r3582224238
##########
superset-frontend/src/components/Chart/DrillDetail/DrillDetailTableControls.stories.tsx:
##########
@@ -33,4 +33,9 @@ InteractiveTableControls.args = {
{ op: '>', col: 'tz_offset', val: 200 },
{ op: '==', col: 'platform', val: 'GB' },
],
+ canDownload: true,
+ onDownloadCSV: () => {},
+ onDownloadXLSX: () => {},
+ onReload: () => {},
+ loading: false,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing required prop setFilters</b></div>
<div id="fix">
The `InteractiveTableControls.args` is missing the required `setFilters`
prop defined in `TableControlsProps` (line 37). Without it, the component will
crash with a TypeError at line 78 of `DrillDetailTableControls.tsx` when any
filter removal is attempted. Compare to the test file which correctly provides
this prop at line 22.
</div>
</div>
<small><i>Code Review Run #08cb42</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
