yousoph commented on PR #40978: URL: https://github.com/apache/superset/pull/40978#issuecomment-4974037966
Thanks for the review @rusackas! Rebased onto latest master to clear the conflict (`FilterValue.tsx` imports collided with the lodash-es migration from #41511 — kept `lodash-es` and the `shallowEqual` addition; the guard logic merged cleanly around the new time-range/semantic-layer changes from #40000/#40475). Also addressed the test-style nit: the nested `describe` block is now three flat `test()` calls (8ba47b6). All 9 FilterValue tests pass. Agreed on the zero-row `defaultToFirstItem` parent edge case — leaving that as a follow-up (unblock-on-settled-empty) rather than growing this PR's scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
