john-bodley opened a new pull request #8436: [fix] Updating parse_human_timedelta typing URL: https://github.com/apache/incubator-superset/pull/8436 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY This PR fixes a regression introduced in https://github.com/apache/incubator-superset/pull/8409 as per the typing for `parse_human_timedelta`. As part of the PR I believed that `s` needed to be a `str` yet it was being passed an `Optional[str]` and thus I ensures this wasn't the case. The logic I added in `QueryObject` was wrong where in fact `s` was of type `Optional[str]`. ### TEST PLAN Added additional unit test. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS to: @etr2460 @graceguo-supercat @michellethomas @mistercrunch
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
