codeant-ai-for-open-source[bot] commented on code in PR #39255:
URL: https://github.com/apache/superset/pull/39255#discussion_r3591309480
##########
tests/integration_tests/charts/data/api_tests.py:
##########
@@ -403,6 +404,47 @@ def test_with_excel_result_format(self):
assert rv.status_code == 200
assert rv.mimetype == mimetype
+ @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
+ def test_csv_export_filename_contains_chart_name(self):
Review Comment:
**Suggestion:** Add an explicit return type annotation to this new test
method (for example, `-> None`) to satisfy the required type-hint rule.
[custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This new test method omits an explicit return type annotation such as `->
None`, which violates the Python type-hint requirement for newly added or
modified code.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=defb887ab9f145499635990ec70c33ff&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=defb887ab9f145499635990ec70c33ff&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/charts/data/api_tests.py
**Line:** 408:408
**Comment:**
*Custom Rule: Add an explicit return type annotation to this new test
method (for example, `-> None`) to satisfy the required type-hint rule.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39255&comment_hash=92a453ed2505e62ab3c02497eb50fd441e0ed716bed576f93bfa0c92076f141f&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39255&comment_hash=92a453ed2505e62ab3c02497eb50fd441e0ed716bed576f93bfa0c92076f141f&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
