rusackas commented on PR #39068:
URL: https://github.com/apache/superset/pull/39068#issuecomment-4986403350
@massucattoj I gave this a rebase onto current `master` (the antd v6 upgrade
had tangled up the paste/search bits in `AsyncSelect`/`Select`), and CI's green
again. While I was in here I cleared out most of the bot threads too.
I pushed one small fix in efa6457 for the in-place `.sort()` mutation
@jesperct spotted, sorting a copy now. And I resolved the recurring
"single-separator split" flags, since that just preserves the existing paste
behavior (the old code split on a single separator too), so it isn't a
regression.
There are a few design calls I didn't want to make for you, so I left those
threads open: whether the unconditional `preventDefault()` on paste should be
gated so non-tokenizable text isn't dropped; whether the new
`setInputValue('')` should respect `autoClearSearchValue={false}`; the
`onSearch`/`showSearch` vs `allowNewOptions` gating; the escaped literal-quote
edge case (`"Bob ""Builder"""`); and whether the tokenization flow wants
component-level tests beyond the util unit tests. None look like blockers to
me, but they're worth a pass.
Thanks for your patience on the long road here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
