codeant-ai-for-open-source[bot] commented on code in PR #42099: URL: https://github.com/apache/superset/pull/42099#discussion_r3592699234
########## superset/translations/th/LC_MESSAGES/messages.po: ########## @@ -30960,6 +31076,7 @@ msgstr "deck.gl เส้นชั้นความสูง" # Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs, # de, es, ja, lv, mi, nl, pt_BR, ru, sk, sl, uk] +#. do-not-translate Review Comment: **Suggestion:** The newly added do-not-translate marker contradicts the entry’s translated output (the value differs from the source token), which makes the catalog policy inconsistent. Either remove the do-not-translate marker for this key or make the output exactly match the source token. [comment mismatch] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ deck.gl GeoJSON token inconsistent with internal i18n policy. - ⚠️ Future i18n automation may mis-handle deck.gl GeoJSON token. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Open the Thai catalog `/superset/translations/th/LC_MESSAGES/messages.po` and navigate to lines 31078–31082, which define the deck.gl Geojson chart label (verified via Grep). 2. Observe at line 31079 the comment `#. do-not-translate`, followed by `#, fuzzy`, then `msgid "deck.gl Geojson"` at line 31081 and `msgstr "deck.gl GeoJSON"` at line 31082, where the msgstr differs from the msgid by capitalization. 3. Use Grep on the same file for `#. do-not-translate` (lines 947–32322) and confirm that other do-not-translate entries such as `msgid "ECharts"`, `msgid "dttm"`, `msgid "sql"`, and `msgid "p1"` either have an empty `msgstr` or a `msgstr` identical to the `msgid`, indicating the project policy that these tokens should not be localized. 4. Comparing this pattern with the deck.gl Geojson block shows that the `#. do-not-translate` marker conflicts with a changed msgstr; this inconsistency means the token is treated both as a non-translatable identifier and as a translated label, making catalog policy unstable and suggesting the marker or msgstr should be adjusted for consistency. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=61e482db1ab84c7f824bec49dd3869f2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=61e482db1ab84c7f824bec49dd3869f2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/th/LC_MESSAGES/messages.po **Line:** 31079:31079 **Comment:** *Comment Mismatch: The newly added do-not-translate marker contradicts the entry’s translated output (the value differs from the source token), which makes the catalog policy inconsistent. Either remove the do-not-translate marker for this key or make the output exactly match the source token. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42099&comment_hash=36c5986186b2195cbef0d6155615e5750028d618f0dfcde458e6caa6c15155d6&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42099&comment_hash=36c5986186b2195cbef0d6155615e5750028d618f0dfcde458e6caa6c15155d6&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
