bito-code-review[bot] commented on PR #42103:
URL: https://github.com/apache/superset/pull/42103#issuecomment-4988532591
<!-- Bito Reply -->
The suggestion to add an explicit type annotation to the `_LANG_CODE_RE`
constant is correct and aligns with standard Python typing practices for
module-level constants. You can resolve this by importing `Pattern` from the
`re` module and annotating the variable as follows:
```python
import re
from typing import Pattern
_LANG_CODE_RE: Pattern[str] =
re.compile(r"[a-z]{2,3}(_([A-Z]{2}|[A-Z][a-z]{3}))?")
```
There are no other comments on this pull request to address. Would you like
me to implement this change for you?
**scripts/translations/backfill_po.py**
```
import re
from typing import Pattern
_LANG_CODE_RE: Pattern[str] =
re.compile(r"[a-z]{2,3}(_([A-Z]{2}|[A-Z][a-z]{3}))?")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
