rusackas commented on PR #31981: URL: https://github.com/apache/superset/pull/31981#issuecomment-4988544097
Went back through my own rebase commit and the `%(name)s.pdf` mismatch I flagged earlier (still translated as `.csv`) is still in there. `msgfmt --check-format` also finds 6 fatal errors on this branch that `master` doesn't have, including `Applied filters (%s)` coming back as `Filtros aplicados (%d)`, which throws at runtime for non-integer values. Still curious what folks think on the tú vs usted question from before, too. Let me know if you have feelings there, want me to get some opinions (or want to raise it on the dev@ mailing list), or if I should... just make an executive decision here to merge and move forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
