codeant-ai-for-open-source[bot] commented on code in PR #41502:
URL: https://github.com/apache/superset/pull/41502#discussion_r3593414841
##########
superset/commands/report/execute.py:
##########
@@ -569,22 +571,28 @@ def _get_screenshots(self) -> list[bytes]:
"Screenshot failed; aborting to avoid sending a
partial report"
)
imges.append(imge)
- elapsed_seconds = (datetime.utcnow() - start_time).total_seconds()
+ elapsed_seconds = (
+ datetime.now(timezone.utc).replace(tzinfo=None) - start_time
+ ).total_seconds()
Review Comment:
**Suggestion:** Add an explicit type annotation to this new elapsed-time
local variable (for example, annotate it as a float) to satisfy the type-hint
requirement. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This is a newly added local variable in Python code that can be annotated
with a concrete type, so it matches the type-hint requirement rule.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6428710962034cc79e67d8c1cb9c6260&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6428710962034cc79e67d8c1cb9c6260&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 574:576
**Comment:**
*Custom Rule: Add an explicit type annotation to this new elapsed-time
local variable (for example, annotate it as a float) to satisfy the type-hint
requirement.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=6176529744c311305377e87ce611b5ecd10a323c4fabd930bd646f4b9f3a46c7&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=6176529744c311305377e87ce611b5ecd10a323c4fabd930bd646f4b9f3a46c7&reaction=dislike'>๐</a>
##########
superset/commands/report/execute.py:
##########
@@ -759,7 +767,9 @@ def _get_data(self, result_format: ChartDataResultFormat)
-> bytes:
request_payload=request_payload,
timeout=app.config["ALERT_REPORTS_CSV_REQUEST_TIMEOUT"],
)
- elapsed_seconds = (datetime.utcnow() - start_time).total_seconds()
+ elapsed_seconds = (
+ datetime.now(timezone.utc).replace(tzinfo=None) - start_time
+ ).total_seconds()
Review Comment:
**Suggestion:** Add an explicit type annotation to this newly added
`elapsed_seconds` variable in data-generation logging. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This added local variable is used for logging and can be annotated, but no
type hint is present, so the rule violation is real.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=605c40c4a2ff4402addb2e1ad5f3a51d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=605c40c4a2ff4402addb2e1ad5f3a51d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 770:772
**Comment:**
*Custom Rule: Add an explicit type annotation to this newly added
`elapsed_seconds` variable in data-generation logging.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=3c0e20e9014a6d723054032266573b2309a081e3358b70f5a0e599baae0f81f0&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=3c0e20e9014a6d723054032266573b2309a081e3358b70f5a0e599baae0f81f0&reaction=dislike'>๐</a>
##########
superset/commands/report/execute.py:
##########
@@ -569,22 +571,28 @@ def _get_screenshots(self) -> list[bytes]:
"Screenshot failed; aborting to avoid sending a
partial report"
)
imges.append(imge)
- elapsed_seconds = (datetime.utcnow() - start_time).total_seconds()
+ elapsed_seconds = (
+ datetime.now(timezone.utc).replace(tzinfo=None) - start_time
+ ).total_seconds()
logger.info(
"Screenshot capture took %.2fs - execution_id: %s",
elapsed_seconds,
self._execution_id,
)
except SoftTimeLimitExceeded as ex:
- elapsed_seconds = (datetime.utcnow() - start_time).total_seconds()
+ elapsed_seconds = (
+ datetime.now(timezone.utc).replace(tzinfo=None) - start_time
+ ).total_seconds()
Review Comment:
**Suggestion:** Add a type hint to this added `elapsed_seconds` assignment
in the timeout branch so the new variable declaration is fully typed.
[custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The timeout handler introduces a new local value computed from
`total_seconds()`, and it is not type-annotated. That is a real omission under
the Python type-hint rule.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5c1e17961fbb450fa31452f745956ad3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5c1e17961fbb450fa31452f745956ad3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 583:585
**Comment:**
*Custom Rule: Add a type hint to this added `elapsed_seconds`
assignment in the timeout branch so the new variable declaration is fully typed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=95a13c4ecda2e3f2350464ec06c1134c918d31a095ac20a4ffbe6af85b1cad0d&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=95a13c4ecda2e3f2350464ec06c1134c918d31a095ac20a4ffbe6af85b1cad0d&reaction=dislike'>๐</a>
##########
superset/commands/report/execute.py:
##########
@@ -1453,7 +1476,9 @@ def run(self) -> None:
self._execution_id, self._model, self._scheduled_dttm
).run()
- elapsed_seconds = (datetime.utcnow() - start_time).total_seconds()
+ elapsed_seconds = (
+ datetime.now(timezone.utc).replace(tzinfo=None) - start_time
+ ).total_seconds()
Review Comment:
**Suggestion:** Add an explicit type annotation to this newly added
`elapsed_seconds` variable in command execution logging. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This newly added execution-duration variable is untyped despite being a
clear candidate for annotation, so the suggestion correctly identifies a real
violation.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0dc0308989894278a0f7d15b9396d585&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0dc0308989894278a0f7d15b9396d585&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 1479:1481
**Comment:**
*Custom Rule: Add an explicit type annotation to this newly added
`elapsed_seconds` variable in command execution logging.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=55a84d8ec6ccf03de3ce5358eca6bd0043717cbae1b9e7b4b7d8e9396c3494f6&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=55a84d8ec6ccf03de3ce5358eca6bd0043717cbae1b9e7b4b7d8e9396c3494f6&reaction=dislike'>๐</a>
##########
superset/commands/report/execute.py:
##########
@@ -810,7 +824,9 @@ def _get_embedded_data(self) -> pd.DataFrame:
auth_cookies,
timeout=app.config["ALERT_REPORTS_CSV_REQUEST_TIMEOUT"],
)
- elapsed_seconds = (datetime.utcnow() - start_time).total_seconds()
+ elapsed_seconds = (
+ datetime.now(timezone.utc).replace(tzinfo=None) - start_time
+ ).total_seconds()
Review Comment:
**Suggestion:** Add a type hint to this new `elapsed_seconds` assignment in
embedded-data processing to comply with the required typing rule. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The embedded-data path adds a new local timing variable without an explicit
annotation, which fits the custom type-hint rule.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5e3f702dff8744d49d417f9049a8d2a7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5e3f702dff8744d49d417f9049a8d2a7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 827:829
**Comment:**
*Custom Rule: Add a type hint to this new `elapsed_seconds` assignment
in embedded-data processing to comply with the required typing rule.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=b8ea0cc6f54b03025edf1fcbffff02937480f7d28289ad8f8f7fd592342dea3f&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=b8ea0cc6f54b03025edf1fcbffff02937480f7d28289ad8f8f7fd592342dea3f&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
