codeant-ai-for-open-source[bot] commented on code in PR #41976:
URL: https://github.com/apache/superset/pull/41976#discussion_r3596043723
##########
superset-frontend/src/visualizations/TimeTable/utils/sortUtils/sortUtils.test.ts:
##########
@@ -16,26 +16,16 @@
* specific language governing permissions and limitations
* under the License.
*/
+
import { sortNumberWithMixedTypes } from './sortUtils';
-import type { ColumnConfig } from '../../types';
// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from
describe blocks
describe('sortNumberWithMixedTypes', () => {
- const createMockRow = (
- value: any,
- columnOverrides: Partial<ColumnConfig> = {},
- ) => ({
+ const createMockRow = (value: any) => ({
Review Comment:
**Suggestion:** Replace the `any` parameter type with a concrete union type
that matches the values used in these test rows. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The final file still introduces `any` in new TypeScript test code, which
violates the llmcfg-no-any-types rule. A concrete union type should be used
instead.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 16)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6f854d4ac9164ca4b1841d141e2cbc91&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6f854d4ac9164ca4b1841d141e2cbc91&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/visualizations/TimeTable/utils/sortUtils/sortUtils.test.ts
**Line:** 24:24
**Comment:**
*Custom Rule: Replace the `any` parameter type with a concrete union
type that matches the values used in these test rows.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41976&comment_hash=6d846fe84b7f9418991296161e99ba694dd9e58996fb56f11d2d3948251f68fb&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41976&comment_hash=6d846fe84b7f9418991296161e99ba694dd9e58996fb56f11d2d3948251f68fb&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
