msyavuz opened a new pull request, #42112:
URL: https://github.com/apache/superset/pull/42112
### SUMMARY
Upgrades the frontend to React 19 (`react`/`react-dom`/`@types/react` 19,
RTL 16, `@testing-library/dom` 10).
**Draft for visibility** — rebased on current master,
typecheck/lint/prettier green, but the full jest suite, a production build, and
manual verification are still outstanding.
Decisions worth reviewing:
- Master independently landed the `react-loadable` → native renderer swap
and the redux 4 pinning, so those commits from the original branch are dropped.
- `reactify` silently dropped `renderFn.defaultProps` — React 19 ignores
`defaultProps` on function/forwardRef components. Defaults are now merged
explicitly (no compiler catches this; only its test does).
- `@testing-library/user-event` is deliberately **not** bumped to 14. It
isn't required (12.8.3 already peers `@testing-library/dom >=7.21.4`), and
v14's async API would break ~1000 sync call sites while only 2 fail to compile.
Separate PR if we want it.
- AG Grid commits its rows after the initial render under React 19, so a few
tests now await the grid instead of reading the DOM synchronously. The grid
itself renders fine.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — dependency upgrade, no intended visual change.
### TESTING INSTRUCTIONS
`npm run type`, `npm run lint`, `npm run test`. Manually exercise
dashboards, Explore, and the SQL Lab results grid (AG Grid render timing
changed).
### ADDITIONAL INFORMATION
- [ ] Has associated issue: No
- [ ] Required feature flags: None
- [ ] Changes UI: No — no intended visual change
- [ ] Includes DB Migration: No — frontend only
- [ ] Migration is atomic, supports rollback & is backwards-compatible: N/A
- [ ] Confirm DB migration upgrade and downgrade tested: N/A
- [ ] Runtime estimates and downtime expectations provided: N/A
- [ ] Introduces new feature or API: No
- [ ] Removes existing feature or API: No — though `react-loadable` is
removed from dependencies
https://claude.ai/code/session_01W1ZGRXC5g7r9Twzdqw3fgc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
