DamianPendrak commented on PR #38028: URL: https://github.com/apache/superset/pull/38028#issuecomment-4994990428
Hi, I rebased this onto current master and addressed the open review comments. Since I can't push to this fork's branch directly, I've pushed my work to my fork and would appreciate you pulling it onto the PR branch @Boreto1213. Branch: feat/h3-hexagon-layer on https://github.com/DamianPendrak/superset What changed: - Rebased onto master - your 9 original commits are untouched. The plugin directory was renamed on master (legacy-preset-chart-deckgl → preset-chart-deckgl), so there's one completion commit that moves the H3 layer into the renamed plugin and adapts a couple of imports that moved upstream (t → @apache-superset/core/translation). - Then 3 review-fix commits @rusackas: - read h3 config from rawFormData in H3 transformProps - fixes the failing transformProps tests. - emit cross-filter on H3 hexagon click - with emitCrossFilters on, clicking a hexagon threw No valid spatial configuration found in form data because getCrossFilterDataMask had no branch for h3_index. Added one that emits an equality filter on the H3 column. - fit H3 viewport to full hexagon boundaries - auto-zoom used only the first boundary vertex of each hexagon, clipping edge cells; now uses all vertices like Polygon does. @Boreto1213 you can use these commands in your fork to push the rebased version: `git fetch https://github.com/DamianPendrak/superset.git feat/h3-hexagon-layer:rebased-h3` `git push origin --force rebased-h3:feat/h3-hexagon-layer` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
