willbarrett opened a new pull request #8449: Wbarrett/split up db engine test file URL: https://github.com/apache/incubator-superset/pull/8449 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [X] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The db_engine_spec_test.py file was over 800 lines and targeted a number of different databases. It was difficult to find what was targeting which bit of implementation. This PR breaks up that test file into one test file per platform, as well as a base test module to inherit from for shared functionality. This should make it easier to increase test coverage of db_engine_specs going forward. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> Run tests. Test files were refactored. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @betodealmeida @mistercrunch @dpgaspar
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
