john-bodley opened a new pull request #8450: [SIP-15] Making client time UTC URL: https://github.com/apache/incubator-superset/pull/8450 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Whilst playing with the time range picker I discovered that for relative times ("Last Week" etc.) the reference time (either shown in default or via a tooltip) would use the client timezone rather than the server timezone. This was problematic say at 2019-10-24:18:00:00 PDT the UI would reference `2019-10-24 00:00:00` in various tooltips however when the query was executed it would use `2019-10-25 00:00:00`. Note I was unsure whether we should parse the server timezone to the client but it seems in other places there's the assumption that times use the UTC timezone (irrespective of the server timezone). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF I added a tooltip to explicitly callout that the times were in UTC.  ### TEST PLAN CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS to: @betodealmeida @etr2460 @mistercrunch cc: @vylc
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
