sadpandajoe commented on code in PR #42075:
URL: https://github.com/apache/superset/pull/42075#discussion_r3599507655
##########
superset-frontend/src/dashboard/reducers/dashboardState.test.ts:
##########
@@ -206,7 +207,95 @@ describe('DashboardState reducer', () => {
}),
);
});
+
+ // Pins PLAN.md ยง4.1: a nested-tab switch must not drop a hydrate-seeded
+ // outer ancestor from activeTabs. setActiveTab's inactiveTabs/prevTabId
+ // removal only targets the tab being left and its descendants, so an
+ // outer ancestor that is neither must survive. This property is what the
+ // repurposed `nativeFilters/state.test.ts` "full Redux-supplied path"
+ // test assumes holds once hydration seeds the default tab path.
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
