rusackas commented on PR #33946: URL: https://github.com/apache/superset/pull/33946#issuecomment-4999267591
First, I can't rebase this anyway, since it's from your `master` branch, so the guardrails won't even let me. But also, on second thought, thinking through the feature and permissions here a bit more. If a user can't edit a chart, why shouldn't they be allowed to SEE it on the welcome page? They still have permission to view it, so why not see it? You mentioned they don't see saved queries if they don't have view/read permission on them, which makes sense, but if they have permission to view the chart, why not _let_ them, and even fiddle with the control panels, but just not _save_ it? Isn't that more true to what those permissions are for? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
