codeant-ai-for-open-source[bot] commented on code in PR #42126:
URL: https://github.com/apache/superset/pull/42126#discussion_r3600570678


##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Contour/Contour.tsx:
##########
@@ -113,12 +107,6 @@ export const getLayer: GetLayerType<ContourLayer> = 
function ({
     },
   );
 
-  if (jsFnMutator) {
-    // Applying user defined data mutator if defined
-    const jsFnMutatorFunction = sandboxedEval(fd.js_data_mutator);
-    data = jsFnMutatorFunction(data);
-  }
-
   // Create wrapper for tooltip content that adds nearby points
   const tooltipContentGenerator = (o: any) => {

Review Comment:
   **Suggestion:** Change the tooltip callback parameter from `any` to a 
specific hover info/type definition that matches the object shape consumed in 
the function. [custom_rule]
   
   **Severity Level:** Major ⚠️
   <details>
   <summary><b>Why it matters? ⭐ </b></summary>
   
   The final file still uses `any` for the tooltip callback parameter, so the 
suggested violation of the no-any rule is real.
   </details>
   <details>
   <summary><b>Rule source 📖 </b></summary>
   
   .cursor/rules/dev-standard.mdc (line 16)
   </details>
   
   [![Fix in 
Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=773f420775894efd870385ecaea4f82a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
 [![Fix in VSCode 
Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=773f420775894efd870385ecaea4f82a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** 
superset-frontend/plugins/preset-chart-deckgl/src/layers/Contour/Contour.tsx
   **Line:** 111:111
   **Comment:**
        *Custom Rule: Change the tooltip callback parameter from `any` to a 
specific hover info/type definition that matches the object shape consumed in 
the function.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve 
this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask 
user if the user wants to fix the rest of the comments as well. if said yes, 
then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42126&comment_hash=66ac41e1883826294836dd929d74dcd8ec14a8b89073616df2e092f2d72a194f&reaction=like'>👍</a>
 | <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42126&comment_hash=66ac41e1883826294836dd929d74dcd8ec14a8b89073616df2e092f2d72a194f&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to