bito-code-review[bot] commented on code in PR #40507:
URL: https://github.com/apache/superset/pull/40507#discussion_r3603834424
##########
helm/superset/tests/labels_test.yaml:
##########
@@ -185,6 +188,36 @@ tests:
path: metadata.labels["app.kubernetes.io/component"]
value: websocket
+ #
=============================================================================
+ # MCP Deployment Labels
+ #
=============================================================================
+ - it: should have all recommended labels on mcp deployment
+ template: deployment-mcp.yaml
+ set:
+ supersetMcp.enabled: true
+ asserts:
+ - isNotNull:
+ path: metadata.labels["app.kubernetes.io/name"]
+ - isNotNull:
+ path: metadata.labels["app.kubernetes.io/instance"]
+ - isNotNull:
+ path: metadata.labels["app.kubernetes.io/version"]
+ - isNotNull:
+ path: metadata.labels["app.kubernetes.io/managed-by"]
+ - isNotNull:
+ path: metadata.labels["app.kubernetes.io/part-of"]
+ - isNotNull:
+ path: metadata.labels["app.kubernetes.io/component"]
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing helm.sh/chart assertion</b></div>
<div id="fix">
The 'should have all recommended labels on mcp deployment' test is missing
the `helm.sh/chart` assertion that the main deployment test includes. The
`superset.labels` macro (line 70 in _helpers.tpl) generates this label, so it
will be present in the rendered template. Adding this assertion ensures
consistent test coverage per the Kubernetes recommended labels standard
documented at line 41-42.
</div>
</div>
<small><i>Code Review Run #400f71</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
